gh-130110: Support hyphens in RFC 2231 continuation parameter names#153536
Open
Phantom-d-e-v wants to merge 2 commits into
Open
gh-130110: Support hyphens in RFC 2231 continuation parameter names#153536Phantom-d-e-v wants to merge 2 commits into
Phantom-d-e-v wants to merge 2 commits into
Conversation
…ames Parameter names containing hyphens (e.g. `file-name*0*`) were not recognized as RFC 2231 continuations because the matching regular expression only allowed `\w+`. As a result, such parameters were left undecoded by `email.utils.decode_params`. Adjust the regular expression to also accept hyphens (`[\w-]+`), which matches the production behaviour for non-hyphenated names. Fixes: pythongh-130110
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameter names containing hyphens (e.g.
file-name*0*) were not recognized as RFC 2231 continuations because the matching regular expression only allowed\w+. As a result, such parameters were left undecoded byemail.utils.decode_params.Adjust the regular expression to also accept hyphens (
[\w-]+), which matches the production behaviour for non-hyphenated names.Fixes: gh-130110